Skip to content

Conversation

@MelonWang1
Copy link
Contributor

@MelonWang1 MelonWang1 commented Oct 16, 2024

Related #10773

Proposed changes

  • Add unit test DesignerExtendersTests.cs for public properties and method of the DesignerExtenders.
  • Enable nullability in DesignerExtenders.
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.65293%. Comparing base (572677b) to head (9c9c0eb).
Report is 11 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12337         +/-   ##
===================================================
+ Coverage   75.60672%   75.65293%   +0.04621%     
===================================================
  Files           3115        3120          +5     
  Lines         635138      635407        +269     
  Branches       46921       46937         +16     
===================================================
+ Hits          480207      480704        +497     
+ Misses        151479      151242        -237     
- Partials        3452        3461          +9     
Flag Coverage Δ
Debug 75.65293% <100.00000%> (+0.04621%) ⬆️
integration 18.28311% <ø> (+0.00035%) ⬆️
production 49.21279% <ø> (+0.08097%) ⬆️
test 97.02702% <100.00000%> (+0.00169%) ⬆️
unit 46.19000% <ø> (+0.11899%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dotnet-policy-service dotnet-policy-service bot added the waiting-author-feedback The team requires more information from the author label Oct 18, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Oct 18, 2024
@LeafShi1 LeafShi1 added the waiting-review This item is waiting on review by one or more members of team label Oct 18, 2024
LeafShi1
LeafShi1 previously approved these changes Oct 18, 2024
@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Oct 18, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Oct 21, 2024
@lonitra lonitra added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Oct 21, 2024
@LeafShi1 LeafShi1 merged commit 65c6beb into dotnet:main Oct 22, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Oct 22, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Oct 22, 2024
@MelonWang1 MelonWang1 deleted the Add_unit_tests_for_DesignerExtenders branch October 22, 2024 06:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants