Skip to content

Fixes the Remove() and IndexOf() methods in the ImageListDesigner.OriginalImageCollection class and adds coverage to it #12282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LeafShi1 merged 1 commit into from
Oct 12, 2024
Merged

Fixes the Remove() and IndexOf() methods in the ImageListDesigner.OriginalImageCollection class and adds coverage to it #12282

LeafShi1 merged 1 commit into from
Oct 12, 2024

Conversation

@ricardobossan
Copy link
Member

@ricardobossan ricardobossan commented Oct 8, 2024 •
edited
Loading

Fixes #12291
Related #10773

Proposed changes

  • Fixes the Remove() and IndexOf() methods in the ImageListDesigner.OriginalImageCollection class, which had the wrong argument types in their signatures;
  • Adds code coverage for that class.

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests

Test environment(s)

  • 9.0.100-rc.1.24452.12

@ricardobossan ricardobossan self-assigned this Oct 8, 2024
@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label Oct 8, 2024
@ricardobossan ricardobossan force-pushed the Issue_10773_ImageListDesigner.OriginalImageCollection branch from 0cc3f1e to 76811c1 Compare October 8, 2024 23:06
@ricardobossan ricardobossan marked this pull request as ready for review October 8, 2024 23:07
@ricardobossan ricardobossan requested a review from a team as a code owner October 8, 2024 23:07
@ricardobossan ricardobossan added waiting-review This item is waiting on review by one or more members of team and removed draft draft PR labels Oct 8, 2024
@ricardobossan ricardobossan mentioned this pull request Oct 8, 2024
Closed
@ricardobossan ricardobossan force-pushed the Issue_10773_ImageListDesigner.OriginalImageCollection branch from 76811c1 to aa36b7a Compare October 9, 2024 20:40
@codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.53086% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.56186%. Comparing base (0c96068) to head (fe3f4e8).
Report is 86 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #12282         +/-   ##
===================================================
+ Coverage   75.26750%   75.56186%   +0.29435%     
===================================================
  Files           3086        3111         +25     
  Lines         633636      635122       +1486     
  Branches       46839       46914         +75     
===================================================
+ Hits          476922      479910       +2988     
+ Misses        153310      151753       -1557     
- Partials        3404        3459         +55
Flag Coverage Δ
Debug 75.56186% <97.53086%> (+0.29435%) ⬆️
integration 18.29579% <0.00000%> (+0.28362%) ⬆️
production 49.03896% <33.33333%> (+0.46301%) ⬆️
test 97.03079% <100.00000%> (+0.00762%) ⬆️
unit 46.00256% <33.33333%> (+0.39245%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Oct 9, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Oct 9, 2024
@ricardobossan ricardobossan changed the title Adds coverage to ImageListDesigner.OriginalImageCollection Fixes the Remove() and IndexOf() methods in the ImageListDesigner.OriginalImageCollection class and adds coverage to it Oct 9, 2024
@ricardobossan ricardobossan added the waiting-review This item is waiting on review by one or more members of team label Oct 9, 2024
@ricardobossan
Copy link
Member Author

ricardobossan commented Oct 9, 2024

@Tanya-Solyanik Initially, this PR focused on adding tests for the ImageListDesigner.OriginalImageCollection class. However, during this process, I discovered bugs that resulted in the creation of issue #12291. Since resolving #12291 would require adding new tests to the same class already under review in this PR, I decided it would be more efficient to expand this PR to include the fix for #12291 and add full test coverage for the class, including tests for the code fix.

@ricardobossan ricardobossan force-pushed the Issue_10773_ImageListDesigner.OriginalImageCollection branch from 1afe074 to 9234b3f Compare October 9, 2024 23:55
@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Oct 10, 2024
Epica3055
Epica3055 reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@Epica3055 Epica3055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides last comment, looks good. 👍

Fixes dotnet#12291 and adds coverage to ImageListDesigner.OriginalIma…
fe3f4e8 
…geCollection

Fixes dotnet#12291
Related dotnet#10773

## Proposed changes

- Fixes the `Remove()` and `IndexOf()` methods in the
`ImageListDesigner.OriginalImageCollection` class, which had the wrong
argument types in their signatures;
- Adds code coverage for that class.

## Customer Impact

- None

## Regression?

- No

## Risk

- Minimal

## Test methodology

- Unit tests

## Test environment(s)

- 9.0.100-rc.1.24452.12
@ricardobossan ricardobossan force-pushed the Issue_10773_ImageListDesigner.OriginalImageCollection branch from 9234b3f to fe3f4e8 Compare October 11, 2024 21:31
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Oct 11, 2024
Tanya-Solyanik
Tanya-Solyanik approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Oct 11, 2024
@LeafShi1 LeafShi1 merged commit 0469577 into dotnet:main Oct 12, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Oct 12, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Oct 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Epica3055 Epica3055 Epica3055 left review comments

@lonitra lonitra Awaiting requested review from lonitra

@LeafShi1 LeafShi1 Awaiting requested review from LeafShi1

@SimonZhao888 SimonZhao888 Awaiting requested review from SimonZhao888

+1 more reviewer

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ricardobossan ricardobossan

Labels

None yet

Projects

None yet

Milestone

10.0 Preview1

Development

Successfully merging this pull request may close these issues.

ImageListDesigner.OriginalImageCollection.Remove() and IndexOf() methods do not handle ImageListImage correctly

4 participants

@ricardobossan @Tanya-Solyanik @Epica3055 @LeafShi1