Skip to content

Conversation

@Liv-Goh
Copy link
Contributor

@Liv-Goh Liv-Goh commented Oct 4, 2024

Related #10773

Proposed changes

  1. Add unit test SplitterPanelDesignerTests.cs for public properties and method of the SplitterPanelDesigner.
  2. Enable nullability in SplitterPanelDesignerTests.cs.
Microsoft Reviewers: Open in CodeFlow

@Liv-Goh Liv-Goh requested a review from a team as a code owner October 4, 2024 03:22
@codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.65086%. Comparing base (935f877) to head (3c0af76).
Report is 124 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12269         +/-   ##
===================================================
+ Coverage   75.23555%   75.65086%   +0.41530%     
===================================================
  Files           3082        3116         +34     
  Lines         633299      635349       +2050     
  Branches       46823       46930        +107     
===================================================
+ Hits          476466      480647       +4181     
+ Misses        153436      151248       -2188     
- Partials        3397        3454         +57     
Flag Coverage Δ
Debug 75.65086% <100.00000%> (+0.41530%) ⬆️
integration 18.29935% <ø> (+0.28174%) ⬆️
production 49.21385% <ø> (+0.68491%) ⬆️
test 97.02596% <100.00000%> (+0.00406%) ⬆️
unit 46.17521% <ø> (+0.63235%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Liv-Goh Liv-Goh added the waiting-review This item is waiting on review by one or more members of team label Oct 4, 2024
@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Oct 7, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Oct 16, 2024
@Liv-Goh Liv-Goh added the waiting-review This item is waiting on review by one or more members of team label Oct 17, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonitra lonitra added ready-to-merge PRs that are ready to merge but worth notifying the internal team. and removed waiting-review This item is waiting on review by one or more members of team labels Oct 17, 2024
@LeafShi1 LeafShi1 merged commit d198602 into dotnet:main Oct 18, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Oct 18, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Oct 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants