Skip to content

Conversation

@LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Sep 29, 2024

Related #10773

Proposed changes

  • Add test file MaskedTextBoxTextEditorDropDownTests.cs for MaskedTextBoxTextEditorDropDown
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.45297%. Comparing base (0d0e1c9) to head (3878723).
Report is 30 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12244         +/-   ##
===================================================
+ Coverage   75.42712%   75.45297%   +0.02584%     
===================================================
  Files           3102        3106          +4     
  Lines         634244      634374        +130     
  Branches       46866       46882         +16     
===================================================
+ Hits          478392      478654        +262     
+ Misses        152434      152292        -142     
- Partials        3418        3428         +10     
Flag Coverage Δ
Debug 75.45297% <100.00000%> (+0.02584%) ⬆️
integration 17.98308% <ø> (+0.00350%) ⬆️
production 48.85334% <ø> (+0.04964%) ⬆️
test 97.02558% <100.00000%> (-0.00066%) ⬇️
unit 45.88770% <ø> (+0.05183%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comment, LGTM

@ricardobossan ricardobossan added waiting-author-feedback The team requires more information from the author waiting-review This item is waiting on review by one or more members of team labels Sep 30, 2024
@Tanya-Solyanik Tanya-Solyanik removed the waiting-review This item is waiting on review by one or more members of team label Oct 1, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Oct 8, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lonitra lonitra merged commit 3894dca into dotnet:main Oct 8, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Oct 8, 2024
@LeafShi1 LeafShi1 deleted the Add_tests_for_MaskedTextBoxTextEditorDropDown branch October 9, 2024 00:12
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants