Adds code coverage to ImageIndexEditor #12237
Merged
+43
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardobossan
force-pushed
the
Issue_10773_Add_Coverage_To_ImageIndexEditor
branch
2 times, most recently
from
2ac5e61 to
ac57679
Compare
ricardobossan
added
waiting-review
ricardobossan
requested review from
Epica3055,
LeafShi1,
SimonZhao888,
Tanya-Solyanik and
lonitra
lonitra
reviewed
Oct 3, 2024
Member
lonitra
left a comment
lonitra
left a comment
There was a problem hiding this comment.
Couple of small comments about target type new otherwise LGTM
...em.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ImageIndexEditorTests.cs
Outdated
Show resolved
Hide resolved
...em.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ImageIndexEditorTests.cs
Outdated
Show resolved
Hide resolved
lonitra
added
waiting-author-feedback
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12237 +/- ##
===================================================
+ Coverage 75.43346% 75.44473% +0.01127%
===================================================
Files 3103 3104 +1
Lines 634314 634316 +2
Branches 46876 46876
===================================================
+ Hits 478485 478558 +73
+ Misses 152403 152334 -69
+ Partials 3426 3424 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Related dotnet#10773 ## Proposed changes - Adds coverage for public properties and methods of the `ImageIndexEditor` class. ## Customer Impact - None ## Regression? - No ## Risk - Minimal ## Test methodology - Unit tests ## Test environment(s) - 9.0.100-rc.1.24452.12
ricardobossan
force-pushed
the
Issue_10773_Add_Coverage_To_ImageIndexEditor
branch
from
ac57679 to
5808153
Compare
dotnet-policy-service
bot
removed
the
waiting-author-feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
ImageIndexEditorclass.Customer Impact
Regression?
Risk
Test methodology
Test environment(s)