Skip to content

Conversation

@Olina-Zhang
Copy link
Member

@Olina-Zhang Olina-Zhang commented Sep 23, 2024

Related #10773

Proposed changes

  • Add unit test ToolStripContainerDesignerTests.cs for public properties and method of the ToolStripContainerDesigner.
  • Enable nullability in ToolStripContainerDesignerTests.cs.
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 94.82759% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.46095%. Comparing base (99d42a9) to head (3d1888e).
Report is 68 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12200         +/-   ##
===================================================
+ Coverage   75.26640%   75.46095%   +0.19454%     
===================================================
  Files           3086        3106         +20     
  Lines         633636      634401        +765     
  Branches       46839       46879         +40     
===================================================
+ Hits          476915      478725       +1810     
+ Misses        153316      152252       -1064     
- Partials        3405        3424         +19     
Flag Coverage Δ
Debug 75.46095% <94.82759%> (+0.19454%) ⬆️
integration 17.98449% <ø> (-0.03683%) ⬇️
production 48.86954% <ø> (+0.29711%) ⬆️
test 97.02524% <94.82759%> (+0.00121%) ⬆️
unit 45.88172% <ø> (+0.27266%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lonitra lonitra added the waiting-author-feedback The team requires more information from the author label Sep 26, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 29, 2024
@lonitra lonitra added the waiting-author-feedback The team requires more information from the author label Sep 30, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Oct 8, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lonitra lonitra merged commit da8495a into dotnet:main Oct 8, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Oct 8, 2024
@Olina-Zhang Olina-Zhang deleted the UnitTest_ToolStripContainerDesigner branch October 15, 2024 02:37
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants