Skip to content

Add unit tests for ItemTypeToolStripMenuItem #12199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tanya-Solyanik merged 7 commits into from
Oct 10, 2024
Merged

Add unit tests for ItemTypeToolStripMenuItem #12199

Tanya-Solyanik merged 7 commits into from
Oct 10, 2024

Conversation

@Syareel-Sukeri
Copy link
Contributor

@Syareel-Sukeri Syareel-Sukeri commented Sep 23, 2024 •
edited by dotnet-policy-service bot
Loading

Related #10773

Proposed changes

  • Add unit test ItemTypeToolStripMenuItemTests.cs for public properties and method of the ItemTypeToolStripMenuItem.
  • Enable nullability in ItemTypeToolStripMenuItem.
Microsoft Reviewers: Open in CodeFlow

@Syareel-Sukeri Syareel-Sukeri requested a review from a team as a code owner September 23, 2024 07:20
@codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.47484%. Comparing base (66894e2) to head (f0e3e7f).
Report is 60 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #12199         +/-   ##
===================================================
+ Coverage   75.34760%   75.47484%   +0.12724%     
===================================================
  Files           3099        3107          +8     
  Lines         634429      634475         +46     
  Branches       46874       46887         +13     
===================================================
+ Hits          478027      478869        +842     
+ Misses        152989      152167        -822     
- Partials        3413        3439         +26
Flag Coverage Δ
Debug 75.47484% <100.00000%> (+0.12724%) ⬆️
integration 17.97674% <0.00000%> (+0.04875%) ⬆️
production 48.89545% <100.00000%> (+0.22043%) ⬆️
test 97.02635% <100.00000%> (-0.00057%) ⬇️
unit 45.93133% <100.00000%> (+0.13831%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Syareel-Sukeri Syareel-Sukeri added the waiting-review This item is waiting on review by one or more members of team label Sep 23, 2024
@Epica3055 Epica3055 added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 25, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 30, 2024
@Syareel-Sukeri Syareel-Sukeri added the waiting-review This item is waiting on review by one or more members of team label Sep 30, 2024
@lonitra lonitra added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 30, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Oct 1, 2024
@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Oct 1, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Oct 2, 2024
@Syareel-Sukeri Syareel-Sukeri added the waiting-review This item is waiting on review by one or more members of team label Oct 2, 2024
@lonitra lonitra added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Oct 8, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Oct 9, 2024
@Syareel-Sukeri Syareel-Sukeri added the waiting-review This item is waiting on review by one or more members of team label Oct 9, 2024
lonitra
lonitra approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lonitra lonitra added ready-to-merge PRs that are ready to merge but worth notifying the internal team. and removed waiting-review This item is waiting on review by one or more members of team labels Oct 10, 2024
@Tanya-Solyanik Tanya-Solyanik merged commit cf5e721 into dotnet:main Oct 10, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Oct 10, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Oct 10, 2024
@Syareel-Sukeri Syareel-Sukeri deleted the AddCodeCovforItemTypeTSMenuItem branch October 24, 2024 08:18
@Syareel-Sukeri Syareel-Sukeri restored the AddCodeCovforItemTypeTSMenuItem branch October 24, 2024 08:18
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Epica3055 Epica3055 Epica3055 left review comments

+2 more reviewers

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik left review comments

@lonitra lonitra lonitra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Syareel-Sukeri Syareel-Sukeri

Labels

None yet

Projects

None yet

Milestone

10.0 Preview1

Development

Successfully merging this pull request may close these issues.

4 participants

@Syareel-Sukeri @Tanya-Solyanik @lonitra @Epica3055