Adds code coverage to FormatStringDialog #12185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardobossan
added
the
waiting-review
ricardobossan
requested review from
Epica3055,
LeafShi1,
SimonZhao888,
Tanya-Solyanik and
lonitra
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12185 +/- ##
===================================================
+ Coverage 75.28764% 75.42387% +0.13622%
===================================================
Files 3097 3102 +5
Lines 634294 634400 +106
Branches 46876 46883 +7
===================================================
+ Hits 477545 478489 +944
+ Misses 153339 152490 -849
- Partials 3410 3421 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/FormatStringDialogTests.cs
Outdated
Show resolved
Hide resolved
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/FormatStringDialogTests.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
waiting-author-feedback
ricardobossan
force-pushed
the
Issue_10773_Add_Code_Coverage_To_FormatStringDialog
branch
from
e24f136 to
d8ed7b4
Compare
dotnet-policy-service
bot
removed
the
waiting-author-feedback
ricardobossan
added
the
waiting-review
Epica3055
reviewed
Sep 24, 2024
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/FormatStringDialogTests.cs
Outdated
Show resolved
Hide resolved
LeafShi1
reviewed
Sep 24, 2024
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/FormatStringDialogTests.cs
Outdated
Show resolved
Hide resolved
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/FormatStringDialogTests.cs
Outdated
Show resolved
Hide resolved
ricardobossan
force-pushed
the
Issue_10773_Add_Code_Coverage_To_FormatStringDialog
branch
from
d8ed7b4 to
c85431f
Compare
lonitra
reviewed
Sep 24, 2024
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/FormatStringDialogTests.cs
Outdated
Show resolved
Hide resolved
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/FormatStringDialogTests.cs
Outdated
Show resolved
Hide resolved
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/FormatStringDialogTests.cs
Outdated
Show resolved
Hide resolved
lonitra
added
waiting-author-feedback
Related dotnet#10773 ## Proposed changes - Adds code coverage for `FormatStringDialog`. ## Customer Impact - None ## Regression? - No ## Risk - Minimal ## Test methodology - Unit tests ## Test environment(s) - 9.0.100-rc.1.24452.12
ricardobossan
force-pushed
the
Issue_10773_Add_Code_Coverage_To_FormatStringDialog
branch
from
c85431f to
28d5a49
Compare
dotnet-policy-service
bot
removed
the
waiting-author-feedback
ricardobossan
added
the
waiting-review
dotnet-policy-service
bot
removed
the
waiting-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
FormatStringDialog.Customer Impact
Regression?
Risk
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow