Skip to content

Conversation

@Olina-Zhang
Copy link
Member

@Olina-Zhang Olina-Zhang commented Sep 13, 2024

Related #10773

Proposed changes

  • Add unit test file: TabControlDesignerTests.cs for public properties and methods of the TabControlDesigner.cs.
  • Enable nullability in TabControlDesignerTests.cs.
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.37933%. Comparing base (463173d) to head (fc1f907).
Report is 59 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12130         +/-   ##
===================================================
+ Coverage   75.18905%   75.37933%   +0.19028%     
===================================================
  Files           3073        3098         +25     
  Lines         632769      634414       +1645     
  Branches       46794       46879         +85     
===================================================
+ Hits          475773      478217       +2444     
+ Misses        153610      152784        -826     
- Partials        3386        3413         +27     
Flag Coverage Δ
Debug 75.37933% <96.66667%> (+0.19028%) ⬆️
integration 18.02072% <ø> (-0.01973%) ⬇️
production 48.76188% <ø> (+0.33544%) ⬆️
test 97.02690% <96.66667%> (+0.00498%) ⬆️
unit 45.79784% <ø> (+0.40108%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Sep 13, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 14, 2024
@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Sep 14, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 18, 2024
@lonitra lonitra added the waiting-author-feedback The team requires more information from the author label Sep 18, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 19, 2024
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit a4480b8 into dotnet:main Sep 19, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Sep 19, 2024
@Olina-Zhang Olina-Zhang deleted the UnitTest_TabControlDesigner branch September 23, 2024 07:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants