Skip to content

Conversation

@Syareel-Sukeri
Copy link
Contributor

@Syareel-Sukeri Syareel-Sukeri commented Sep 11, 2024

Related #10773

Proposed changes

  • Add unit test PrintDialogDesignerTests.cs for public properties and method of the PrintDialogDesigner.cs
  • Enable nullability in PrintDialogDesignerTests.cs
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.23300%. Comparing base (77da9f6) to head (d90439e).
Report is 14 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12117         +/-   ##
===================================================
+ Coverage   75.21424%   75.23300%   +0.01876%     
===================================================
  Files           3076        3080          +4     
  Lines         633053      633262        +209     
  Branches       46814       46823          +9     
===================================================
+ Hits          476146      476422        +276     
+ Misses        153515      153444         -71     
- Partials        3392        3396          +4     
Flag Coverage Δ
Debug 75.23300% <100.00000%> (+0.01876%) ⬆️
integration 18.02112% <ø> (-0.00379%) ⬇️
production 48.52647% <ø> (+0.03321%) ⬆️
test 97.02157% <100.00000%> (-0.00165%) ⬇️
unit 45.53970% <ø> (+0.04796%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Syareel-Sukeri Syareel-Sukeri added the waiting-review This item is waiting on review by one or more members of team label Sep 11, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lonitra lonitra merged commit cfcfed2 into dotnet:main Sep 12, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Sep 12, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Sep 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
@Syareel-Sukeri Syareel-Sukeri deleted the AddCodeCovPrintDialogDesigner branch October 24, 2024 08:18
@Syareel-Sukeri Syareel-Sukeri restored the AddCodeCovPrintDialogDesigner branch October 24, 2024 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants