Skip to content

Conversation

@Nora-Zhou01
Copy link
Contributor

@Nora-Zhou01 Nora-Zhou01 commented Sep 11, 2024

Related #10773

Proposed changes

  • Add unit test PanelDesignerTests.cs for public properties and method of the PanelDesigner.cs
  • Enable nullability in PanelDesignerTests.cs
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.23768%. Comparing base (e4085eb) to head (623239a).
Report is 119 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12113         +/-   ##
===================================================
+ Coverage   75.01536%   75.23768%   +0.22231%     
===================================================
  Files           3047        3083         +36     
  Lines         631584      633305       +1721     
  Branches       46764       46823         +59     
===================================================
+ Hits          473785      476484       +2699     
+ Misses        154434      153427       -1007     
- Partials        3365        3394         +29     
Flag Coverage Δ
Debug 75.23768% <100.00000%> (+0.22231%) ⬆️
integration 18.01901% <ø> (+0.08461%) ⬆️
production 48.53315% <ø> (+0.40851%) ⬆️
test 97.02194% <100.00000%> (+0.00547%) ⬆️
unit 45.55059% <ø> (+0.42445%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Nora-Zhou01 Nora-Zhou01 added the waiting-review This item is waiting on review by one or more members of team label Sep 11, 2024
@LeafShi1 LeafShi1 added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 12, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 12, 2024
LeafShi1
LeafShi1 previously approved these changes Sep 12, 2024
@lonitra lonitra added the waiting-author-feedback The team requires more information from the author label Sep 12, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 13, 2024
@Tanya-Solyanik Tanya-Solyanik merged commit 72429cb into dotnet:main Sep 13, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Sep 13, 2024
@Nora-Zhou01 Nora-Zhou01 deleted the Add-unit-tests-for-PanelDesigner branch September 30, 2024 06:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants