Skip to content

Conversation

@Olina-Zhang
Copy link
Member

@Olina-Zhang Olina-Zhang commented Sep 10, 2024

Related #10773

Proposed changes

  • Add unit test file: TabPageDesignerTests.cs for public properties of the TabPageDesigner.cs.
  • Enable nullability in TabPageDesignerTests.cs.
Microsoft Reviewers: Open in CodeFlow

@Olina-Zhang Olina-Zhang requested a review from a team as a code owner September 10, 2024 10:11
@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Sep 10, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 11, 2024
@codecov
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.23838%. Comparing base (463173d) to head (708a39f).
Report is 39 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12097         +/-   ##
===================================================
+ Coverage   75.18905%   75.23838%   +0.04933%     
===================================================
  Files           3073        3083         +10     
  Lines         632769      633339        +570     
  Branches       46794       46823         +29     
===================================================
+ Hits          475773      476514        +741     
+ Misses        153610      153432        -178     
- Partials        3386        3393          +7     
Flag Coverage Δ
Debug 75.23838% <100.00000%> (+0.04933%) ⬆️
integration 18.01231% <ø> (-0.02815%) ⬇️
production 48.53315% <ø> (+0.10671%) ⬆️
test 97.02108% <100.00000%> (-0.00084%) ⬇️
unit 45.55235% <ø> (+0.15558%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the waiting-review This item is waiting on review by one or more members of team label Sep 11, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comment, LGTM.

@ricardobossan ricardobossan added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 12, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 12, 2024
ricardobossan
ricardobossan previously approved these changes Sep 12, 2024
@lonitra lonitra added the waiting-author-feedback The team requires more information from the author label Sep 12, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 13, 2024
@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Sep 13, 2024
@Olina-Zhang Olina-Zhang removed the waiting-author-feedback The team requires more information from the author label Sep 14, 2024
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit a3cb46a into dotnet:main Sep 14, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Sep 14, 2024
@Olina-Zhang Olina-Zhang deleted the UnitTest_TabPageDesigner branch September 18, 2024 01:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants