Skip to content

Conversation

@Philip-Wang01
Copy link
Contributor

@Philip-Wang01 Philip-Wang01 commented Sep 10, 2024

Related #10773

Proposed changes

  • Add unit test TextBoxDesignerTests.cs for public properties and method of the TextBoxDesigner.cs
  • Enable nullability in TextBoxDesignerTests.cs
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.19576%. Comparing base (463173d) to head (c36284c).
Report is 23 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12095         +/-   ##
===================================================
+ Coverage   75.18905%   75.19576%   +0.00671%     
===================================================
  Files           3073        3074          +1     
  Lines         632769      632787         +18     
  Branches       46794       46794                 
===================================================
+ Hits          475773      475829         +56     
+ Misses        153610      153570         -40     
- Partials        3386        3388          +2     
Flag Coverage Δ
Debug 75.19576% <100.00000%> (+0.00671%) ⬆️
integration 18.04221% <ø> (+0.00176%) ⬆️
production 48.43979% <ø> (+0.01335%) ⬆️
test 97.02208% <100.00000%> (+0.00016%) ⬆️
unit 45.40978% <ø> (+0.01301%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the waiting-review This item is waiting on review by one or more members of team label Sep 10, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardobossan ricardobossan added waiting-author-feedback The team requires more information from the author waiting-review This item is waiting on review by one or more members of team and removed waiting-review This item is waiting on review by one or more members of team waiting-author-feedback The team requires more information from the author labels Sep 12, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lonitra lonitra merged commit e5d30c6 into dotnet:main Sep 12, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Sep 12, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Sep 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants