Skip to content

Conversation

@Nora-Zhou01
Copy link
Contributor

@Nora-Zhou01 Nora-Zhou01 commented Sep 10, 2024

Related #10773

Proposed changes

  • Add unit test ListAdapterTests.cs for public properties and method of the ListAdapter.
  • Enable nullability in ListAdapter.
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.23596%. Comparing base (e4085eb) to head (a05b1de).
Report is 111 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12093         +/-   ##
===================================================
+ Coverage   75.01536%   75.23596%   +0.22060%     
===================================================
  Files           3047        3080         +33     
  Lines         631584      633261       +1677     
  Branches       46764       46823         +59     
===================================================
+ Hits          473785      476440       +2655     
+ Misses        154434      153426       -1008     
- Partials        3365        3395         +30     
Flag Coverage Δ
Debug 75.23596% <100.00000%> (+0.22060%) ⬆️
integration 18.02288% <ø> (+0.08848%) ⬆️
production 48.53315% <ø> (+0.40851%) ⬆️
test 97.02156% <100.00000%> (+0.00508%) ⬆️
unit 45.54005% <ø> (+0.41391%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the waiting-review This item is waiting on review by one or more members of team label Sep 10, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comment, LGTM.

@LeafShi1 LeafShi1 added the waiting-author-feedback The team requires more information from the author label Sep 12, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 12, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lonitra lonitra merged commit a4a0740 into dotnet:main Sep 12, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Sep 12, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Sep 12, 2024
@Nora-Zhou01 Nora-Zhou01 deleted the Add-core-coverage-for-ListAdapter branch September 23, 2024 08:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants