Skip to content

Conversation

@MelonWang1
Copy link
Contributor

@MelonWang1 MelonWang1 commented Sep 9, 2024

Related #10773

Proposed changes

  • Add unit test ControlDesigner.DesignerControlCollectionTests.cs for public properties and method of the ControlDesigner.DesignerControlCollection.
  • Enable nullability in ControlDesigner.DesignerControlCollection.
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 96.26168% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.38899%. Comparing base (10ce899) to head (848cbf9).
Report is 68 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12085         +/-   ##
===================================================
+ Coverage   75.16445%   75.38899%   +0.22454%     
===================================================
  Files           3070        3099         +29     
  Lines         632561      634521       +1960     
  Branches       46788       46880         +92     
===================================================
+ Hits          475461      478359       +2898     
+ Misses        153724      152752        -972     
- Partials        3376        3410         +34     
Flag Coverage Δ
Debug 75.38899% <96.26168%> (+0.22454%) ⬆️
integration 18.02565% <ø> (+0.05774%) ⬆️
production 48.77558% <ø> (+0.38501%) ⬆️
test 97.02666% <96.26168%> (+0.00655%) ⬆️
unit 45.81084% <ø> (+0.40345%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Sep 9, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 10, 2024
@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Sep 10, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 11, 2024
@lonitra lonitra added the waiting-author-feedback The team requires more information from the author label Sep 11, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 12, 2024
Copy link
Member

@LeafShi1 LeafShi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one little comment

@LeafShi1 LeafShi1 added the waiting-author-feedback The team requires more information from the author label Sep 12, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 12, 2024
@lonitra lonitra added the waiting-author-feedback The team requires more information from the author label Sep 12, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 13, 2024
lonitra
lonitra previously approved these changes Sep 13, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Sep 13, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 14, 2024
@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Sep 16, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 20, 2024
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit 90475d3 into dotnet:main Sep 20, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Sep 20, 2024
@MelonWang1 MelonWang1 deleted the Add-unit-tests-for-ControlDesigner.DesignerControlCollection branch September 20, 2024 06:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants