Skip to content

Conversation

@ricardobossan
Copy link
Member

@ricardobossan ricardobossan commented Sep 6, 2024

Related #10773

Proposed changes

  • Adds code coverage for RichTextBoxDesginer

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests

Test environment(s)

  • 9.0.100-preview.7.24407.12
Microsoft Reviewers: Open in CodeFlow

@ricardobossan ricardobossan self-assigned this Sep 6, 2024
@ricardobossan ricardobossan force-pushed the Issue_10773_Add_Code_Coverage_For_RichTextBoxDesigner branch from 9917624 to 9c3a307 Compare September 6, 2024 02:34
@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label Sep 6, 2024
@codecov
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.22518%. Comparing base (c4dcefb) to head (8a16327).
Report is 28 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12061         +/-   ##
===================================================
+ Coverage   75.15884%   75.22518%   +0.06633%     
===================================================
  Files           3069        3079         +10     
  Lines         632551      633171        +620     
  Branches       46787       46814         +27     
===================================================
+ Hits          475418      476304        +886     
+ Misses        153745      153475        -270     
- Partials        3388        3392          +4     
Flag Coverage Δ
Debug 75.22518% <100.00000%> (+0.06633%) ⬆️
integration 18.02054% <ø> (+0.06094%) ⬆️
production 48.51182% <ø> (+0.13430%) ⬆️
test 97.02320% <100.00000%> (+0.00311%) ⬆️
unit 45.51788% <ø> (+0.12117%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardobossan ricardobossan force-pushed the Issue_10773_Add_Code_Coverage_For_RichTextBoxDesigner branch from d35cd2a to 6090e85 Compare September 6, 2024 22:48
@ricardobossan ricardobossan marked this pull request as ready for review September 6, 2024 22:49
@ricardobossan ricardobossan requested a review from a team as a code owner September 6, 2024 22:49
@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed draft draft PR labels Sep 6, 2024
@ricardobossan ricardobossan force-pushed the Issue_10773_Add_Code_Coverage_For_RichTextBoxDesigner branch from 6090e85 to 6b724b3 Compare September 6, 2024 23:42
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 6, 2024
@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Sep 7, 2024
@ricardobossan ricardobossan force-pushed the Issue_10773_Add_Code_Coverage_For_RichTextBoxDesigner branch from 6b724b3 to 466fa6a Compare September 10, 2024 10:27
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 10, 2024
@Tanya-Solyanik
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Sep 10, 2024
Tanya-Solyanik
Tanya-Solyanik previously approved these changes Sep 10, 2024
@Tanya-Solyanik
Copy link
Contributor

Looks good, but CI build had failed, I restarted it. Feel free to merge if it passes

Related dotnet#10773

## Proposed changes

- Adds code coverage for RichTextBoxDesginer

## Customer Impact

- None

## Regression?

- No

## Risk

- Minimal

## Test methodology

- Unit tests

## Test environment(s)

- 9.0.100-preview.7.24407.12
@ricardobossan ricardobossan force-pushed the Issue_10773_Add_Code_Coverage_For_RichTextBoxDesigner branch from 466fa6a to 8a16327 Compare September 11, 2024 20:30
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 11, 2024
@Tanya-Solyanik Tanya-Solyanik merged commit a4e8292 into dotnet:main Sep 11, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Sep 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants