Skip to content

Conversation

@Philip-Wang01
Copy link
Contributor

@Philip-Wang01 Philip-Wang01 commented Sep 3, 2024

Related #10773

Proposed changes

  • Add unit test CustomMenuItemCollectionTests.cs for public properties and method of the CustomMenuItemCollection.
  • Enable nullability in CustomMenuItemCollection.
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.09426%. Comparing base (d876f24) to head (e33edd3).
Report is 13 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12035         +/-   ##
===================================================
+ Coverage   75.07100%   75.09426%   +0.02326%     
===================================================
  Files           3063        3065          +2     
  Lines         632075      632292        +217     
  Branches       46784       46785          +1     
===================================================
+ Hits          474505      474815        +310     
+ Misses        154194      154102         -92     
+ Partials        3376        3375          -1     
Flag Coverage Δ
Debug 75.09426% <100.00000%> (+0.02326%) ⬆️
integration 17.92824% <ø> (-0.01482%) ⬇️
production 48.25541% <ø> (+0.03306%) ⬆️
test 97.01793% <100.00000%> (+0.00158%) ⬆️
unit 45.28333% <ø> (+0.03412%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the waiting-review This item is waiting on review by one or more members of team label Sep 3, 2024
@LeafShi1 LeafShi1 added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 4, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 4, 2024
@ricardobossan ricardobossan added the waiting-author-feedback The team requires more information from the author label Sep 4, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Sep 5, 2024
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Sep 5, 2024
@lonitra lonitra merged commit b1d43cb into dotnet:main Sep 5, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Sep 5, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Sep 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants