Adds code coverage to FolderNameEditor #11973
Merged
+55
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardobossan
added
the
waiting-review
ricardobossan
requested review from
Epica3055,
LeafShi1,
SimonZhao888,
Tanya-Solyanik and
lonitra
Tanya-Solyanik
added
waiting-author-feedback
Contributor
Tanya-Solyanik
left a comment
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Please investigate the build failure
...em.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/FolderNameEditorTests.cs
Outdated
Show resolved
Hide resolved
ricardobossan
force-pushed
the
Issue_10773_Add_Coverage_FolderNameEditor
branch
from
fab1487 to
074eb65
Compare
dotnet-policy-service
bot
removed
the
waiting-author-feedback
ricardobossan
force-pushed
the
Issue_10773_Add_Coverage_FolderNameEditor
branch
from
074eb65 to
df7ffe1
Compare
...em.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/FolderNameEditorTests.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
the
waiting-author-feedback
ricardobossan
force-pushed
the
Issue_10773_Add_Coverage_FolderNameEditor
branch
from
df7ffe1 to
031819e
Compare
dotnet-policy-service
bot
removed
the
waiting-author-feedback
ricardobossan
force-pushed
the
Issue_10773_Add_Coverage_FolderNameEditor
branch
from
031819e to
be5e88b
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ricardobossan
force-pushed
the
Issue_10773_Add_Coverage_FolderNameEditor
branch
2 times, most recently
from
455d8f0 to
8ea6a8b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11973 +/- ##
===================================================
- Coverage 75.06986% 75.06846% -0.00141%
===================================================
Files 3059 3063 +4
Lines 632006 632075 +69
Branches 46782 46784 +2
===================================================
+ Hits 474446 474489 +43
- Misses 154188 154207 +19
- Partials 3372 3379 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
Author
@Tanya-Solyanik I moved the test to the correct namespace ( Error details from the pipeline: @azure-pipelines |
Related dotnet#10773 ## Proposed changes - Adds code coverage to `FolderNameEditor` ## Customer Impact - None ## Regression? - No ## Risk - Minimal ## Test methodology - Unit tests ## Test environment(s) - 9.0.100-preview.7.24407.12
ricardobossan
force-pushed
the
Issue_10773_Add_Coverage_FolderNameEditor
branch
from
8ea6a8b to
7979d0c
Compare
ricardobossan
added
the
waiting-review
Member
Author
|
@lonitra @LeafShi1 @Epica3055 @SimonZhao888 Checks now pass. Could you please review this PR? |
lonitra
added
ready-to-merge
dotnet-policy-service
bot
removed
the
ready-to-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
FolderNameEditorCustomer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow