Skip to content

Conversation

@MelonWang1
Copy link
Contributor

@MelonWang1 MelonWang1 commented Aug 21, 2024

Related #10773

Proposed changes

  • Add unit test MaskPropertyEditorTests.cs for public properties and method of the MaskPropertyEditor.
  • Enable nullability in MaskPropertyEditor.
Microsoft Reviewers: Open in CodeFlow

@MelonWang1 MelonWang1 requested a review from a team as a code owner August 21, 2024 09:29
@codecov
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.04472%. Comparing base (e4085eb) to head (5d3e2dd).
Report is 33 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11955         +/-   ##
===================================================
+ Coverage   75.01536%   75.04472%   +0.02935%     
===================================================
  Files           3047        3056          +9     
  Lines         631584      631714        +130     
  Branches       46764       46767          +3     
===================================================
+ Hits          473785      474068        +283     
+ Misses        154434      154278        -156     
- Partials        3365        3368          +3     
Flag Coverage Δ
Debug 75.04472% <84.00000%> (+0.02935%) ⬆️
integration 17.93609% <ø> (+0.00168%) ⬆️
production 48.18491% <ø> (+0.06027%) ⬆️
test 97.01484% <84.00000%> (-0.00163%) ⬇️
unit 45.21511% <ø> (+0.08897%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Aug 22, 2024
@lonitra lonitra merged commit ede8883 into dotnet:main Aug 23, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Aug 23, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Aug 23, 2024
@MelonWang1 MelonWang1 deleted the Add-unit-tests-for-MaskPropertyEditor branch August 26, 2024 01:10
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants