Skip to content

Conversation

@Philip-Wang01
Copy link
Contributor

@Philip-Wang01 Philip-Wang01 commented Aug 21, 2024

Related #10773

Proposed changes

  • Add unit test ContextMenuStripGroupCollectionTests.cs for public properties and method of the ContextMenuStripGroupCollection.
  • Enable nullability in ContextMenuStripGroupCollection.
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.06049%. Comparing base (1e4ffb8) to head (cb05aaa).
Report is 14 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11952         +/-   ##
===================================================
+ Coverage   75.02949%   75.06049%   +0.03100%     
===================================================
  Files           3047        3056          +9     
  Lines         631649      631901        +252     
  Branches       46766       46776         +10     
===================================================
+ Hits          473923      474308        +385     
+ Misses        154357      154225        -132     
+ Partials        3369        3368          -1     
Flag Coverage Δ
Debug 75.06049% <100.00000%> (+0.03100%) ⬆️
integration 17.93855% <ø> (+0.00402%) ⬆️
production 48.20285% <ø> (+0.05149%) ⬆️
test 97.01702% <100.00000%> (+0.00112%) ⬆️
unit 45.23305% <ø> (+0.05030%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the waiting-review This item is waiting on review by one or more members of team label Aug 22, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, otherwise 👍

@lonitra lonitra added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Aug 22, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Aug 23, 2024
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit 14acefa into dotnet:main Aug 24, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Aug 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants