Skip to content

Add unit tests for CompositionDesigner #11888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lonitra merged 2 commits into from
Aug 21, 2024
Merged

Add unit tests for CompositionDesigner #11888

lonitra merged 2 commits into from
Aug 21, 2024
+18 −0

Conversation

@Philip-Wang01
Copy link
Contributor

@Philip-Wang01 Philip-Wang01 commented Aug 15, 2024 •
edited by dotnet-policy-service bot
Loading

Related #10773

Proposed changes

  • Add unit test CompositionDesignerTests.cs for public properties and method of the CompositionDesigner.
  • Enable nullability in CompositionDesigner.
Microsoft Reviewers: Open in CodeFlow

@Philip-Wang01 Philip-Wang01 requested a review from a team as a code owner August 15, 2024 06:39
@codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.02363%. Comparing base (e4085eb) to head (25d4500).
Report is 28 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #11888         +/-   ##
===================================================
+ Coverage   75.01536%   75.02363%   +0.00826%     
===================================================
  Files           3047        3048          +1     
  Lines         631584      631629         +45     
  Branches       46764       46767          +3     
===================================================
+ Hits          473785      473871         +86     
+ Misses        154434      154397         -37     
+ Partials        3365        3361          -4
Flag Coverage Δ
Debug 75.02363% <100.00000%> (+0.00826%) ⬆️
integration 17.93684% <ø> (+0.00243%) ⬆️
production 48.14191% <ø> (+0.01727%) ⬆️
test 97.01537% <100.00000%> (-0.00110%) ⬇️
unit 45.14067% <ø> (+0.01453%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

ricardobossan

This comment was marked as duplicate.

Sign in to view

@LeafShi1
Copy link
Member

LeafShi1 commented Aug 16, 2024

@Tanya-Solyanik @lonitra The class CompositionDesigner does not implement any functions, and there is no place to call it in the entire Winform repo. Do we need to add unit tests for it?

@Tanya-Solyanik
Copy link
Contributor

Tanya-Solyanik commented Aug 16, 2024

@Tanya-Solyanik @lonitra The class CompositionDesigner does not implement any functions, and there is no place to call it in the entire Winform repo. Do we need to add unit tests for it?

Good point! Let's add a single test to indicate that this is not implemented, something like this -

    [Fact]
    public void Designer_ThrowsNotImplementedException()
    {
        using ComponentDocumentDesigner designer = new();
        using Timer timer = new();
        designer.Initialize(timer);
        designer.Invoking(d => d.Component).Should().Throw<NotImplementedException>();
     }

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Aug 16, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Aug 20, 2024
@lonitra lonitra merged commit 9df46fa into dotnet:main Aug 21, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Aug 21, 2024
@LeafShi1 LeafShi1 mentioned this pull request Aug 26, 2024
Open
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ricardobossan ricardobossan ricardobossan left review comments

@LeafShi1 LeafShi1 LeafShi1 left review comments

+1 more reviewer

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Philip-Wang01 Philip-Wang01

Labels

None yet

Projects

None yet

Milestone

10.0 Preview1

Development

Successfully merging this pull request may close these issues.

5 participants

@Philip-Wang01 @LeafShi1 @Tanya-Solyanik @ricardobossan @lonitra