Add unit tests for ListViewActionList #11782
Merged
+84
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tanya-Solyanik
added
the
waiting-author-feedback
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ListViewActionListTests.cs
Show resolved
Hide resolved
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ListViewActionListTests.cs
Outdated
Show resolved
Hide resolved
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ListViewActionListTests.cs
Outdated
Show resolved
Hide resolved
dotnet-policy-service
bot
removed
the
waiting-author-feedback
Tanya-Solyanik
previously approved these changes
Aug 7, 2024
Contributor
Tanya-Solyanik
left a comment
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Looks good, but please fix the CI build failure.
Tanya-Solyanik
added
the
waiting-author-feedback
Contributor
Author
Sorry, I cannot fix this CI build failure and rerun doesn't solve the problem. I'll try resubmitting the same PR tomorrow to see if I'll still have CI build failure. |
dotnet-policy-service
bot
added
untriaged
lonitra
reviewed
Aug 8, 2024
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ListViewActionListTests.cs
Outdated
Show resolved
Hide resolved
lonitra
added
waiting-author-feedback
dotnet-policy-service
bot
removed
the
waiting-author-feedback
Contributor
|
@MelonWang1 - do tests pass on your local machine? If you can't reproduce failure locally, then work with Leaf and team investigating the CI failure |
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ListViewActionListTests.cs
Outdated
Show resolved
Hide resolved
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ListViewActionListTests.cs
Show resolved
Hide resolved
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ListViewActionListTests.cs
Show resolved
Hide resolved
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ListViewActionListTests.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
the
waiting-author-feedback
Tanya-Solyanik
requested review from
Epica3055,
LeafShi1,
SimonZhao888 and
ricardobossan
dotnet-policy-service
bot
removed
the
waiting-author-feedback
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/10.0 #11782 +/- ##
======================================================
+ Coverage 74.94672% 75.01380% +0.06708%
======================================================
Files 3026 3036 +10
Lines 630129 630288 +159
Branches 46738 46687 -51
======================================================
+ Hits 472261 472803 +542
+ Misses 154520 154135 -385
- Partials 3348 3350 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
Author
@Tanya-Solyanik Resolved CI failure. It should be because the InvokeDialogs_ShouldNotThrow() method failed. It gets stuck on the first run. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
Add unit test ListViewTests.cs for public properties and method of the ListViewActionList.
Enable nullability in ListViewActionList.
Microsoft Reviewers: Open in CodeFlow