Skip to content

Conversation

@John-Qiao
Copy link
Contributor

@John-Qiao John-Qiao commented Jul 29, 2024

Related #10773

Proposed changes

  • Add unit test ImageListActionListTests.cs for public properties and method of the ImageListActionList.
  • Enable nullability in ImageListActionList.
Microsoft Reviewers: Open in CodeFlow

@John-Qiao John-Qiao requested a review from a team as a code owner July 29, 2024 02:51
@LeafShi1 LeafShi1 changed the base branch from main to feature/10.0 July 29, 2024 02:54
@John-Qiao John-Qiao added the waiting-review This item is waiting on review by one or more members of team label Jul 29, 2024
@codecov
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.77288%. Comparing base (6a243b0) to head (aeb40a2).
Report is 41 commits behind head on feature/10.0.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/10.0      #11766         +/-   ##
======================================================
+ Coverage      74.68804%   74.77288%   +0.08483%     
======================================================
  Files              3045        3054          +9     
  Lines            631338      631174        -164     
  Branches          47177       46880        -297     
======================================================
+ Hits             471534      471947        +413     
+ Misses           156443      155856        -587     
- Partials           3361        3371         +10     
Flag Coverage Δ
Debug 74.77288% <100.00000%> (+0.08483%) ⬆️
integration 17.86644% <ø> (-0.05796%) ⬇️
production 47.79408% <ø> (+0.08133%) ⬆️
test 96.98826% <100.00000%> (+0.01004%) ⬆️
unit 44.92771% <ø> (+0.18923%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lonitra lonitra merged commit ccd88e2 into dotnet:feature/10.0 Aug 1, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Aug 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants