Skip to content

Conversation

@Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Jul 24, 2024

Related #10773

Proposed changes
Add unit test file: MaskDescriptorTemplateTests.cs for public properties/Methods of the MaskDescriptorTemplate

Microsoft Reviewers: Open in CodeFlow

@Zheng-Li01 Zheng-Li01 requested a review from a team as a code owner July 24, 2024 07:07
@Zheng-Li01 Zheng-Li01 changed the title Add core coverage for mask descriptor template Add core coverage for MaskDescriptorTemplate Jul 24, 2024
@codecov
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.08131%. Comparing base (c0318e5) to head (dc74030).
Report is 39 commits behind head on feature/10.0.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/10.0      #11743         +/-   ##
======================================================
+ Coverage      74.73622%   75.08131%   +0.34508%     
======================================================
  Files              3045        3032         -13     
  Lines            630638      634925       +4287     
  Branches          46862       48287       +1425     
======================================================
+ Hits             471315      476710       +5395     
+ Misses           155957      154805       -1152     
- Partials           3366        3410         +44     
Flag Coverage Δ
Debug 75.08131% <100.00000%> (+0.34508%) ⬆️
integration 18.80797% <ø> (+0.86371%) ⬆️
production 48.70935% <ø> (+0.95141%) ⬆️
test 97.01634% <100.00000%> (+0.03100%) ⬆️
unit 45.72777% <ø> (+0.92289%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Jul 24, 2024
@LeafShi1 LeafShi1 removed the waiting-review This item is waiting on review by one or more members of team label Jul 25, 2024
@Tanya-Solyanik Tanya-Solyanik changed the title Add core coverage for MaskDescriptorTemplate Add code coverage for MaskDescriptorTemplate Jul 27, 2024
lonitra
lonitra previously approved these changes Jul 30, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've retarted this PR to feature/10.0, but please target new PRs that aren't related to regression fixing to feature/10.0 branch

@lonitra lonitra added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jul 30, 2024
@lonitra lonitra changed the base branch from main to feature/10.0 July 30, 2024 16:38
@lonitra lonitra dismissed their stale review July 30, 2024 16:38

The base branch was changed.

@lonitra lonitra merged commit 25e4c5d into dotnet:feature/10.0 Jul 31, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jul 31, 2024
@Zheng-Li01 Zheng-Li01 deleted the Add_core_coverage_for_MaskDescriptorTemplate branch August 7, 2024 01:45
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants