Skip to content

Conversation

@LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Jul 19, 2024

Related #10773

Proposed changes

  • Add unit test ListBoxDesignerTests.cs for public properties and method of the ListBoxDesigner
  • Enable nullability in ListBoxDesigner.
Microsoft Reviewers: Open in CodeFlow

@LeafShi1 LeafShi1 requested a review from a team as a code owner July 19, 2024 10:31
@codecov
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 24 lines in your changes missing coverage. Please review.

Project coverage is 74.80784%. Comparing base (fa07c1b) to head (e81ed29).
Report is 52 commits behind head on feature/10.0.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/10.0      #11712         +/-   ##
======================================================
+ Coverage      74.55969%   74.80784%   +0.24814%     
======================================================
  Files              3041        3053         +12     
  Lines            629780      631125       +1345     
  Branches          46845       46880         +35     
======================================================
+ Hits             469562      472131       +2569     
+ Misses           156849      155626       -1223     
+ Partials           3369        3368          -1     
Flag Coverage Δ
Debug 74.80784% <79.31034%> (+0.24814%) ⬆️
integration 17.95680% <0.00000%> (+0.08405%) ⬆️
production 47.87618% <20.00000%> (+0.42944%) ⬆️
test 96.98754% <100.00000%> (+0.00928%) ⬆️
unit 44.92385% <20.00000%> (+0.35139%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Jul 19, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jul 22, 2024
@lonitra lonitra changed the base branch from main to feature/10.0 July 23, 2024 00:54
@lonitra lonitra added the waiting-author-feedback The team requires more information from the author label Jul 23, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jul 24, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonitra lonitra added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jul 26, 2024
@LeafShi1 LeafShi1 merged commit 1d24bb0 into dotnet:feature/10.0 Jul 29, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jul 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
@LeafShi1 LeafShi1 deleted the Add_tests_ListBoxDesigner branch September 5, 2024 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants