Skip to content

Port TreeNodeCollectionEditor to core#11221

Merged
LeafShi1 merged 6 commits intodotnet:mainfrom
LeafShi1:Issue_11198_Add_TreeNodeCollectionEditor
Apr 19, 2024
Merged

Port TreeNodeCollectionEditor to core#11221
LeafShi1 merged 6 commits intodotnet:mainfrom
LeafShi1:Issue_11198_Add_TreeNodeCollectionEditor

Conversation

@LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Apr 16, 2024 •
edited by dotnet-policy-service bot
Loading

Fixes #11198

Proposed changes

  • Add TreeNodeCollectionEditor (The original code come from VSRepo)

Customer Impact

  • TreeView has the correct TreeNode Editor dialog in PropertyGrid

Regression?

  • Yes

Risk

  • Minimal

Screenshots

Before

There's an incorrect TreeNode Collection Editor dialog for TreeView control.
TreeView-Editor-Actual

After

TreeNode Collection Editor dialog of the TreeView control show correct
ScreenShot

Test methodology

  • Manual (Test changes with project "WinformsControlsTest")

Test environment(s)

  • .net 9.0.0-preview.4.24213.9
Microsoft Reviewers: Open in CodeFlow

@LeafShi1 LeafShi1 requested a review from a team as a code owner April 16, 2024 10:36
@LeafShi1 LeafShi1 requested a review from Tanya-Solyanik April 16, 2024 10:36
@Tanya-Solyanik
Copy link
Contributor

Tanya-Solyanik commented Apr 17, 2024

@LeafShi1 - do you need to update https://github.com/dotnet/winforms/blob/main/eng/Localize/LocProject.json with the new .xlf file?

@LeafShi1
Copy link
Member Author

LeafShi1 commented Apr 17, 2024

@LeafShi1 - do you need to update https://github.com/dotnet/winforms/blob/main/eng/Localize/LocProject.json with the new .xlf file?

Yes, Done.

@codecov
Copy link

codecov bot commented Apr 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 493 lines in your changes are missing coverage. Please review.

Project coverage is 74.29401%. Comparing base (c7aef4e) to head (542095e).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #11221         +/-   ##
===================================================
+ Coverage   73.47335%   74.29401%   +0.82066%     
===================================================
  Files           3101        3010         -91     
  Lines         632447      625469       -6978     
  Branches       46688       46534        -154     
===================================================
+ Hits          464680      464686          +6     
+ Misses        164359      157368       -6991     
- Partials        3408        3415          +7
Flag Coverage Δ
Debug 74.29401% <0.00000%> (+0.82066%) ⬆️
integration 18.32941% <0.00000%> (-0.03445%) ⬇️
production 46.88305% <0.00000%> (-0.07912%) ⬇️
test 97.06513% <ø> (+2.07685%) ⬆️
unit 43.85929% <0.00000%> (-0.07102%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Tanya-Solyanik
Tanya-Solyanik reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Had you tried editing specific nodes from property grid inside this dialog and see if the changes are persisted? For example change the node name or color.

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Apr 17, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Apr 18, 2024
@LeafShi1
Copy link
Member Author

LeafShi1 commented Apr 19, 2024

Looks good! Had you tried editing specific nodes from property grid inside this dialog and see if the changes are persisted? For example change the node name or color.

Yes, I tried to change the properties and they can be persisted AfterChanges

@LeafShi1 LeafShi1 merged commit b79dcdf into dotnet:main Apr 19, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview4 milestone Apr 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SimonZhao888 SimonZhao888 Awaiting requested review from SimonZhao888

@Epica3055 Epica3055 Awaiting requested review from Epica3055

@ricardobossan ricardobossan Awaiting requested review from ricardobossan

1 more reviewer

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LeafShi1 LeafShi1

Labels

None yet

Projects

None yet

Milestone

9.0 Preview4

Development

Successfully merging this pull request may close these issues.

TreeView has the incorrect TreeNode Editor dialog in PropertyGrid

2 participants

@LeafShi1 @Tanya-Solyanik