Enable nullability in GroupedContextMenuStrip and NewItemsContextMenuStrip #11183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpetrou
force-pushed
the
GroupedContextMenuStrip
branch
from
75c6f1b to
c1bcb41
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11183 +/- ##
===================================================
+ Coverage 74.32617% 74.33714% +0.01097%
===================================================
Files 3018 3019 +1
Lines 626381 626411 +30
Branches 46602 46602
===================================================
+ Hits 465565 465656 +91
+ Misses 157419 157364 -55
+ Partials 3397 3391 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
gpetrou
force-pushed
the
GroupedContextMenuStrip
branch
from
c1bcb41 to
a8f1b90
Compare
Member
|
LGTM! @lonitra Please review this PR. |
lonitra
reviewed
Apr 15, 2024
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/GroupedContextMenuStrip.cs
Show resolved
Hide resolved
lonitra
added
the
waiting-author-feedback
gpetrou
force-pushed
the
GroupedContextMenuStrip
branch
from
a8f1b90 to
a9f3bd2
Compare
dotnet-policy-service
bot
removed
the
waiting-author-feedback
elachlan
added
the
waiting-review
lonitra
reviewed
Apr 29, 2024
| [Fact] | ||
| public void Populate_WhenInitializedWithoutGroups_ItemsCountIsZero() | ||
| { | ||
| GroupedContextMenuStrip groupedContextMenuStrip = new(); |
Member
There was a problem hiding this comment.
Believe this is disposable
Suggested change
| GroupedContextMenuStrip groupedContextMenuStrip = new(); | |
| using GroupedContextMenuStrip groupedContextMenuStrip = new(); |
Comment on lines
18
to
19
| GroupedContextMenuStrip groupedContextMenuStrip = new(); | ||
| ToolStripButton toolStripButton = new(); |
Member
There was a problem hiding this comment.
Ditto here and test below as well
Suggested change
| GroupedContextMenuStrip groupedContextMenuStrip = new(); | |
| ToolStripButton toolStripButton = new(); | |
| using GroupedContextMenuStrip groupedContextMenuStrip = new(); | |
| using ToolStripButton toolStripButton = new(); |
lonitra
added
waiting-author-feedback
gpetrou
force-pushed
the
GroupedContextMenuStrip
branch
from
a9f3bd2 to
1730ee2
Compare
dotnet-policy-service
bot
removed
the
waiting-author-feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Microsoft Reviewers: Open in CodeFlow