Fix PrintDialog to return DialogResult.Cancel when cancelled or closed#10928
Merged
JeremyKuhne merged 1 commit intodotnet:mainfrom Feb 22, 2024
Merged
Fix PrintDialog to return DialogResult.Cancel when cancelled or closed#10928JeremyKuhne merged 1 commit intodotnet:mainfrom
PrintDialog to return DialogResult.Cancel when cancelled or closed#10928JeremyKuhne merged 1 commit intodotnet:mainfrom
Conversation
Contributor
Author
|
CC: @JeremyKuhne |
elachlan
added
the
waiting-review
JeremyKuhne
approved these changes
Feb 21, 2024
Member
JeremyKuhne
left a comment
JeremyKuhne
left a comment
There was a problem hiding this comment.
Thanks! I don't know where I got HRESULT from. 😕
JeremyKuhne
removed
the
waiting-review
Contributor
Author
|
Yeah, it happens. At least we have a test now! There are a couple of things I found:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10928 +/- ##
===================================================
+ Coverage 73.16090% 73.17039% +0.00948%
===================================================
Files 3087 3090 +3
Lines 633665 633647 -18
Branches 47402 47398 -4
===================================================
+ Hits 463595 463642 +47
+ Misses 166558 166458 -100
- Partials 3512 3547 +35
Flags with carried forward coverage won't be shown. Click here to find out more. |
KlausLoeffelmann
pushed a commit
to KlausLoeffelmann/winforms
that referenced
this pull request
Mar 5, 2024
…losed (dotnet#10928) Fix PrintDialog to return DialogResult.Cancel when cancelled or closed and add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10920
Microsoft Reviewers: Open in CodeFlow