Update Effects per API review#10919
Merged
JeremyKuhne merged 1 commit intodotnet:mainfrom Feb 21, 2024
Merged
Conversation
This updates Effects to match the approved API and removes [RequiresPreviewFeatures]. Fixes dotnet#8835 dotnet#8835 (comment)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10919 +/- ##
===================================================
- Coverage 73.15837% 73.15735% -0.00103%
===================================================
Files 3087 3090 +3
Lines 633665 633626 -39
Branches 47402 47397 -5
===================================================
- Hits 463579 463544 -35
+ Misses 166572 166569 -3
+ Partials 3514 3513 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
| /// <inheritdoc cref="DrawImage(Image, Effect, RectangleF, Drawing2D.Matrix?, GraphicsUnit, ImageAttributes?)"/> | ||
| public void DrawImage( | ||
| Image image, | ||
| Effect effect) => DrawImage(image, effect, default, default, GraphicsUnit.Pixel, null); |
Contributor
There was a problem hiding this comment.
Add parameter name before the literal
Member
Author
There was a problem hiding this comment.
I'll tweak it in the next PR.
Tanya-Solyanik
approved these changes
Feb 21, 2024
KlausLoeffelmann
pushed a commit
to KlausLoeffelmann/winforms
that referenced
this pull request
Mar 5, 2024
This updates Effects to match the approved API and removes [RequiresPreviewFeatures]. Fixes dotnet#8835 dotnet#8835 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates Effects to match the approved API and removes [RequiresPreviewFeatures].
Fixes #8835
#8835 (comment)
Microsoft Reviewers: Open in CodeFlow