Add ToolStripMenuItem test UI in WinformsControlTests#10914
Merged
LeafShi1 merged 2 commits intodotnet:mainfrom Feb 22, 2024
Merged
Add ToolStripMenuItem test UI in WinformsControlTests#10914LeafShi1 merged 2 commits intodotnet:mainfrom
LeafShi1 merged 2 commits intodotnet:mainfrom
Conversation
Tanya-Solyanik
previously approved these changes
Feb 20, 2024
Contributor
Tanya-Solyanik
left a comment
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
This looks good, but the Form might be more readable if a single ToolsStrip is broken into several, one under the other.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10914 +/- ##
===================================================
- Coverage 73.15679% 73.14115% -0.01565%
===================================================
Files 3087 3090 +3
Lines 633665 633646 -19
Branches 47402 47396 -6
===================================================
- Hits 463569 463456 -113
- Misses 166587 166673 +86
- Partials 3509 3517 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
SimonZhao888
approved these changes
Feb 21, 2024
Tanya-Solyanik
approved these changes
Feb 21, 2024
Tanya-Solyanik
added
the
ready-to-merge
dotnet-policy-service
bot
removed
the
ready-to-merge
Contributor
|
Tested the WinFormsControlTest in the main branch of winforms repo. We can see the added ToolStripMenuItems as following screenshot. |
KlausLoeffelmann
pushed a commit
to KlausLoeffelmann/winforms
that referenced
this pull request
Mar 5, 2024
* Add ToolStripMenuItem test UI in WinformsControlTests * Update the layout of the ToolStrip test page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #10834
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow