Add ComboBoxDesigner tests #10772
Merged
Add ComboBoxDesigner tests #10772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
gpetrou
force-pushed
the
ComboBoxDesignerTests
branch
from
b897bf7 to
fad1d69
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10772 +/- ##
===================================================
+ Coverage 72.65624% 72.67741% +0.02116%
===================================================
Files 2925 2926 +1
Lines 622899 622924 +25
Branches 46925 46925
===================================================
+ Hits 452575 452725 +150
+ Misses 161985 161850 -135
- Partials 8339 8349 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
lonitra
approved these changes
Jan 31, 2024
|
|
||
| Action action = () => _ = comboBoxDesigner.SelectionRules; | ||
|
|
||
| action.Should().ThrowExactly<NullReferenceException>(); |
Member
There was a problem hiding this comment.
This is something that we'll want to change to throw a different exception or not at all to avoid NRE as we enable nullability in the designer space.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Microsoft Reviewers: Open in CodeFlow