Skip to content

Conversation

@gpetrou
Copy link
Contributor

@gpetrou gpetrou commented Jan 31, 2024

Proposed changes

  • Add LabelDesigner tests.
Microsoft Reviewers: Open in CodeFlow

@gpetrou gpetrou requested a review from a team as a code owner January 31, 2024 05:27
@ghost ghost assigned gpetrou Jan 31, 2024
@gpetrou gpetrou force-pushed the LabelDesignerTests branch from 5d23bb4 to 7a38126 Compare January 31, 2024 05:28
@gpetrou gpetrou force-pushed the LabelDesignerTests branch from 7a38126 to 8ba169e Compare January 31, 2024 05:31
@codecov
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82a15d4) 72.65624% compared to head (8ba169e) 72.66341%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10771         +/-   ##
===================================================
+ Coverage   72.65624%   72.66341%   +0.00717%     
===================================================
  Files           2925        2926          +1     
  Lines         622899      622916         +17     
  Branches       46925       46925                 
===================================================
+ Hits          452575      452632         +57     
+ Misses        161985      161940         -45     
- Partials        8339        8344          +5     
Flag Coverage Δ
Debug 72.66341% <100.00000%> (+0.00717%) ⬆️
production 43.50222% <ø> (+0.01400%) ⬆️
test 97.33489% <100.00000%> (+0.00014%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@lonitra lonitra merged commit 843bbc5 into dotnet:main Jan 31, 2024
@ghost ghost added this to the 9.0 Preview2 milestone Jan 31, 2024
@gpetrou gpetrou deleted the LabelDesignerTests branch January 31, 2024 19:31
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants