Add ComponentDesigner tests and fix bugs #1053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1053 +/- ##
===================================================
+ Coverage 31.31542% 32.80829% +1.49287%
===================================================
Files 1097 1098 +1
Lines 318597 320483 +1886
Branches 38398 38870 +472
===================================================
+ Hits 99770 105145 +5375
+ Misses 214645 211141 -3504
- Partials 4182 4197 +15
|
RussKie
reviewed
May 27, 2019
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/ComponentDesigner.cs
Outdated
Show resolved
Hide resolved
RussKie
reviewed
May 27, 2019
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/ComponentDesigner.cs
Outdated
Show resolved
Hide resolved
RussKie
reviewed
May 27, 2019
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/ComponentDesigner.cs
Show resolved
Hide resolved
AdamYoblick
reviewed
May 28, 2019
....Windows.Forms.Design/tests/UnitTests/System/ComponentModel/Design/ComponentDesignerTests.cs
Show resolved
Hide resolved
zsd4yr
reviewed
May 29, 2019
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/ComponentDesigner.cs
Outdated
Show resolved
Hide resolved
zsd4yr
reviewed
May 29, 2019
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/ComponentDesigner.cs
Outdated
Show resolved
Hide resolved
zsd4yr
reviewed
May 29, 2019
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/ComponentDesigner.cs
Show resolved
Hide resolved
hughbe
force-pushed
the
componentdesigner-test-and-fixes
branch
from
945ab07 to
6953385
Compare
zsd4yr
reviewed
May 29, 2019
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/ComponentDesigner.cs
Outdated
Show resolved
Hide resolved
Contributor
|
@hughbe Later on, can you please create one PR per one issue? |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1040
Fixes #1041
Fixes #1045
Fixes #1046
Fixes #1047
Fixes #1048
Fixes #1049
Fixes #1050
Fixes #1051
Fixes #1052