Skip to content

Change PreReleaseVersionLabel to servicing #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dreddy-work merged 1 commit into from
Nov 9, 2022
Merged

Change PreReleaseVersionLabel to servicing #3290

dreddy-work merged 1 commit into from
Nov 9, 2022

Conversation

@dkurepa
Copy link
Member

@dkurepa dkurepa commented Nov 3, 2022

No description provided.

@dreddy-work
Copy link
Member

dreddy-work commented Nov 3, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 3, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@dreddy-work
Copy link
Member

dreddy-work commented Nov 3, 2022

@dkurepa / @mmitche , we need https://github.com/dotnet/arcade/pull/8143/files in release/7.0 branch and flow somehow?

@RussKie
Copy link
Contributor

RussKie commented Nov 3, 2022

@Anipik it looks like dotnet/arcade#8143 was never made to the main branch, which means $(CreatePlatformManifest) is ignored and this flow isn't failing:

windowsdesktop/pkg/windowsdesktop/sfx/Microsoft.WindowsDesktop.App.Ref.sfxproj

Line 10 in 6a4dd16

<CreatePlatformManifest Condition="'$(PreReleaseVersionLabel)' == 'servicing'">false</CreatePlatformManifest>

windowsdesktop/pkg/windowsdesktop/sfx/Microsoft.WindowsDesktop.App.Ref.sfxproj

Lines 76 to 78 in 6a4dd16

<ItemGroup Condition="'$(CreatePlatformManifest)' == 'false'">
<FilesToPackage Include="PlatformManifest.txt" TargetPath="data" GeneratedBuildFile="true" />
</ItemGroup>

@dkurepa dkurepa mentioned this pull request Nov 4, 2022
Merged
@dkurepa
Copy link
Member Author

dkurepa commented Nov 4, 2022

The change made it to the main branch https://github.com/dotnet/arcade/pull/11130/files, the problem is I somehow made an error when making the change on the release/7.0 branch. Here's the fix dotnet/arcade#11510. Think we'll have to update arcade after this is merged

@dreddy-work
Copy link
Member

dreddy-work commented Nov 4, 2022

Thnaks @dkurepa . Please notify us once arcade flow is ready.

@dreddy-work dreddy-work enabled auto-merge (squash) November 4, 2022 18:19
@mmitche
Copy link
Member

mmitche commented Nov 7, 2022

This is waiting on arcade getting promoted to the 7.0 channel. Hopefully should be in the next few hours.

@dreddy-work
Copy link
Member

dreddy-work commented Nov 8, 2022

@mmitche , i do not see arcade update yet. Can you please check?

@mmitche
Copy link
Member

mmitche commented Nov 8, 2022

It just went through the validation stage, so about an hour.

@dreddy-work
Copy link
Member

dreddy-work commented Nov 9, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 9, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@dreddy-work dreddy-work merged commit e7d436e into dotnet:release/7.0 Nov 9, 2022
@RussKie
Copy link
Contributor

RussKie commented Nov 10, 2022

Thank you folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dreddy-work dreddy-work dreddy-work approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dkurepa @dreddy-work @RussKie @mmitche