Skip to content

Conversation

@v-wuzhai
Copy link
Contributor

@v-wuzhai v-wuzhai commented Sep 12, 2023

Fixes #6952 #6949 #6951

@v-wuzhai v-wuzhai requested review from a team and GangWang01 as code owners September 12, 2023 10:35
@v-wuzhai
Copy link
Contributor Author

@dotnet/templating-engine-maintainers would you be able to review these changes?

@v-wuzhai
Copy link
Contributor Author

@mthalman @dotnet/templating-engine-maintainers Could you take a look at the SB errors here?

@mthalman
Copy link
Member

The packages listed in the error will need to be added to the SBRP repo. Instructions for that are here: https://github.com/dotnet/source-build-reference-packages#adding-new-packages. Once merged in that repo, it will cause a dependency flow to update the referenced SBRP in this repo. Merge that update in this PR and the error should go away.

@v-wuzhai
Copy link
Contributor Author

@dotnet/templating-engine-maintainers @mthalman I'm not sure if we don't need updates for these packages?

@mthalman
Copy link
Member

It would seem this PR was accidentally closed, right? In your post for dotnet/source-build-reference-packages#783, it said "fix xxxx" which caused this PR to be closed when that one was merged.

@mthalman mthalman reopened this Sep 18, 2023
@v-wuzhai
Copy link
Contributor Author

/backport to release/8.0.1xx

@github-actions
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants