Skip to content

Conversation

@lbussell
Copy link
Member

Problem

Source Build needs all projects to build with a TargetFramework of net7.0 in order to build without pulling in prebuilt binaries.

Solution

Upgrade dotnet/templating's TargetFramework from net6.0 to net7.0.

Checks:

  • Added unit tests
  • Added #nullable enable to all the modified files ?

@lbussell lbussell requested a review from a team as a code owner July 26, 2022 18:39
@lbussell
Copy link
Member Author

There are many references to net6.0 in ParserTests/InstantiateTests.cs but I'm not sure if/how they should be updated or changed.

Copy link
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any objection to this late change. It doesn't affect NuGet libs, only CLI and tools.
@JanKrivanek @baronfel thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants