This repository was archived by the owner on Sep 13, 2022. It is now read-only.
Adds attribution for APIs previously special-cased by the compiler#1356
Merged
terrajobst merged 1 commit intodotnet:masterfrom Jul 19, 2019
Merged
Adds attribution for APIs previously special-cased by the compiler#1356terrajobst merged 1 commit intodotnet:masterfrom
terrajobst merged 1 commit intodotnet:masterfrom
Conversation
joshpeterson
approved these changes
Jul 19, 2019
jcouv
approved these changes
Jul 19, 2019
jskeet
approved these changes
Jul 19, 2019
marek-safar
approved these changes
Jul 19, 2019
safern
reviewed
Jul 19, 2019
| [System.Diagnostics.ConditionalAttribute("CONTRACTS_FULL")] | ||
| [System.Diagnostics.ConditionalAttribute("DEBUG")] | ||
| public static void Assert(bool condition) { } | ||
| public static void Assert([System.Diagnostics.CodeAnalysis.DoesNotReturnIfAttribute(false)]bool condition) { } |
Member
There was a problem hiding this comment.
Nit: space in between attribute and parameter type.
safern
approved these changes
Jul 19, 2019
Author
|
@stephentoub @agocke any objections? |
stephentoub
approved these changes
Jul 19, 2019
agocke
approved these changes
Jul 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies some of the nullable attributes for APIs that were previously special-cased by the compiler. The attribution is very basic only includes cases where we'e a 100% certain that these are never going to change.
I've arrived here by diffing CoreFX and .NET Standard using the following approach:
Included
DoesNotReturnDoesNotReturnIfConsidered
NotNullWhenExcluded
MaybeNullWhenAttributeMaybeNullAttributeAllowNullAttributeDisallowNullAttributeNotNullAttributeNotNullIfNotNullAttribute@stephentoub @jcouv @dotnet/nullablefc: Please double check my work here.