Skip to content
This repository was archived by the owner on Sep 13, 2022. It is now read-only.

Add IAsyncEnumerable<T> #1017

Merged
terrajobst merged 2 commits into from
Feb 22, 2019
Merged

Add IAsyncEnumerable<T> #1017

terrajobst merged 2 commits into from
Feb 22, 2019

Conversation

@terrajobst
Copy link

@terrajobst terrajobst commented Dec 13, 2018 •
edited
Loading

This reflects the current state on CoreFx.

/cc @stephentoub, you OK with this?

@terrajobst terrajobst added netstandard-api This tracks requests for standardizing APIs. * NO MERGE * Applied to pull-requests that aren't ready to be merged yet. labels Dec 13, 2018
@terrajobst terrajobst added this to the .NET Standard 2.1 milestone Dec 13, 2018
@terrajobst terrajobst requested review from a team as code owners December 13, 2018 19:20
@terrajobst
Copy link
Author

terrajobst commented Dec 13, 2018

@stephentoub, does this look good to you? I've included AsyncIteratorStateMachineAttribute which doesn't seem to be exposed in CoreFx's master yet.

clairernovotny
clairernovotny previously approved these changes Dec 13, 2018
View reviewed changes
@stephentoub
Copy link
Member

stephentoub commented Dec 13, 2018

I've included AsyncIteratorStateMachineAttribute which doesn't seem to be exposed in CoreFx's master yet.

Thank you for the reminder; I apparently neglected to push my changes for this, which I've now done:
dotnet/corefx#34078

stephentoub
stephentoub reviewed Dec 13, 2018
View reviewed changes
stephentoub
stephentoub reviewed Dec 13, 2018
View reviewed changes
stephentoub
stephentoub previously approved these changes Dec 13, 2018
View reviewed changes
@terrajobst terrajobst changed the title Add IAsyncEnumerable<T> WIP: Add IAsyncEnumerable<T> Dec 13, 2018
joshpeterson
joshpeterson previously approved these changes Dec 17, 2018
View reviewed changes
@terrajobst terrajobst changed the base branch from staging/async-disposable to master December 17, 2018 19:12
@danmoseley
Copy link
Member

danmoseley commented Jan 29, 2019

@stephentoub @terrajobst who owns the next action on this? seems the corefx issue is closed.

@terrajobst terrajobst dismissed stale reviews from clairernovotny, stephentoub, and joshpeterson February 21, 2019 01:25

Updated to match CoreFX

@terrajobst terrajobst removed the * NO MERGE * Applied to pull-requests that aren't ready to be merged yet. label Feb 21, 2019
@terrajobst terrajobst changed the title WIP: Add IAsyncEnumerable<T> Add IAsyncEnumerable<T> Feb 21, 2019
stephentoub
stephentoub approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

clairernovotny
clairernovotny approved these changes Feb 21, 2019
View reviewed changes
Copy link

@clairernovotny clairernovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a qustion about whether the private members should be included?

@terrajobst terrajobst removed the request for review from a team February 21, 2019 23:28
@terrajobst
Copy link
Author

terrajobst commented Feb 21, 2019

Removing nsboard-platform as @stephentoub already signed off

@terrajobst
Copy link
Author

terrajobst commented Feb 22, 2019

@dotnet/nsboard-unity, sorry for not waiting for sign-off, but I'd like to get this in before ask mode closes for the upcoming preview. Please let me know if there are any concerns, we can address this in the next preview.

@terrajobst terrajobst merged commit 6f6a785 into dotnet:master Feb 22, 2019
@terrajobst terrajobst deleted the async-enumerable branch February 22, 2019 07:34
@mikaelm12 mikaelm12 mentioned this pull request Apr 18, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

5 more reviewers

@stephentoub stephentoub stephentoub approved these changes

@jaredpar jaredpar jaredpar approved these changes

@marek-safar marek-safar marek-safar approved these changes

@clairernovotny clairernovotny clairernovotny approved these changes

@joshpeterson joshpeterson joshpeterson left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

netstandard-api This tracks requests for standardizing APIs.

Projects

None yet

Milestone

.NET Standard 2.1

Development

Successfully merging this pull request may close these issues.

7 participants

@terrajobst @stephentoub @danmoseley @joshpeterson @jaredpar @marek-safar @clairernovotny