Update projects to net8.0 and move to Central Package Management#123
Merged
ViktorHofer merged 1 commit intodotnet:mainfrom Dec 13, 2023
Merged
Update projects to net8.0 and move to Central Package Management#123ViktorHofer merged 1 commit intodotnet:mainfrom
ViktorHofer merged 1 commit intodotnet:mainfrom
Conversation
Member
|
@garath this unblocks dotnet/arcade#14172 and we want to get that in asap. Does this change look good to you? |
rainersigwald
approved these changes
Dec 13, 2023
Member
|
@garath is out right now so I'm merging this in. We will follow-up on potential post feedback. We might need to update the app service to net8.0 now. |
Member
|
I think there are more package references we can exclude here. I suspect most of those should be loaded from MSBuild and not the app - so long as our repo's CPM versions don't lift them up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dotnet/arcade#14172 we were seeing this issue:
The reason is that the latest version of MSBuild.StructuredLogger depends on Microsoft.Build.Framework 17.5.0, which only ships with net7.0 and net4.7.2 implementation assemblies, but the BinLogToSln tool is targeting net6.0. We didn't see build issues because we're suppressing the NU1701 warning.
To fix this, move to net8.0 for the projects and use Central Package Management. We bump all MSBuild dependencies to 17.5.0 and also stop targeting netstandard2.0 for Common.csproj and BinLogParser.csproj, this allows us to remove the NU1701 suppression and ensures we're getting correct dependencies.
I'm planning on upstreaming the CPM change to https://github.com/KirillOsenkov/SourceBrowser later.