Skip to content

Remove unused NoTargets and Traversal packages #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichaelSimons merged 1 commit into from
Feb 23, 2024
Merged

Remove unused NoTargets and Traversal packages #899

MichaelSimons merged 1 commit into from
Feb 23, 2024

Conversation

@MichaelSimons
Copy link
Member

@MichaelSimons MichaelSimons commented Feb 22, 2024

@MichaelSimons MichaelSimons mentioned this pull request Feb 22, 2024
Closed
@MichaelSimons MichaelSimons marked this pull request as ready for review February 23, 2024 00:14
@MichaelSimons
Copy link
Member Author

MichaelSimons commented Feb 23, 2024

Verified in dotnet/installer#18755.

@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented Feb 23, 2024 •
edited
Loading

Was this also verified in a repo-specific build of a repo that consumes older version of these packages? For instance, diagnostics and cecil both use 3.5.0 of NoTargets SDK. Would it cause a prebuilt failure in source-build leg? I guess prebuilt failure can be fixed at the time of SBRP flow into affected repo.

@MichaelSimons
Copy link
Member Author

MichaelSimons commented Feb 23, 2024 •
edited
Loading

Was this also verified in a repo-specific build of a repo that consumes older version of these packages? For instance, diagnostics and cecil both use 3.5.0 of NoTargets SDK. Would it cause a prebuilt failure in source-build leg? I guess prebuilt failure can be fixed at the time of SBRP flow into affected repo.

Those repos should upgrade when they pick up this version of SBRP. If that is not possible, then they should be added as allowed prebuilts. SBRP should not contain package that are only used in repo level source-build legs.

@MichaelSimons MichaelSimons merged commit f8e2388 into dotnet:main Feb 23, 2024
@MichaelSimons MichaelSimons deleted the delete-unused branch February 23, 2024 14:15
jjonescz added a commit to dotnet/razor that referenced this pull request Feb 27, 2024
@jjonescz
Update Microsoft.Build.NoTargets
3d61ed9 
Per dotnet/source-build-reference-packages#899 (comment).
jjonescz added a commit to dotnet/razor that referenced this pull request Feb 27, 2024
@dotnet-maestro @jjonescz
[main] Update dependencies from dotnet/source-build-reference-packages (
b3ad960 
#9988)

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20240223.3

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24113.1 -> To Version 9.0.0-alpha.1.24123.3

* Update Microsoft.Build.NoTargets

Per dotnet/source-build-reference-packages#899 (comment).

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jan Jones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikolaMilosavljevic NikolaMilosavljevic NikolaMilosavljevic approved these changes

@mthalman mthalman Awaiting requested review from mthalman

@oleksandr-didyk oleksandr-didyk Awaiting requested review from oleksandr-didyk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove old versions of Microsoft.Build.NoTargets and Microsoft.Build.Traversal

2 participants

@MichaelSimons @NikolaMilosavljevic