[release/8.0] Revert "Add xunit abstractions 2.0.3 (#755)" (#784) #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 67acd4b.
mmitche
requested review from
MichaelSimons,
mthalman and
oleksandr-didyk
as code owners
Member
Author
|
Hold on merging this. I think this may break the VMR online build due to prebuilt detection. Want to check first. |
Member
|
I assume you are reverting this change as we don't need that package in favor of arcade's XUnitAssert fork? |
Member
Author
|
Nope. I was thinking this would be an easy way to get this package so it could be used in xunit in source build externals. It has no implementation. But it IS loaded at runtime. |
Member
Author
|
Verified in VMR build. |
ViktorHofer
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 67acd4b.