Add nuget packages #783
Merged
Add nuget packages #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-wuzhai
requested review from
MichaelSimons,
mthalman and
oleksandr-didyk
as code owners
v-wuzhai
force-pushed
the
Jason/AddNugetPackages
branch
from
59228f0 to
b8ddde3
Compare
mthalman
reviewed
Sep 14, 2023
eng/Build.props
Outdated
Comment on lines
32
to
38
| <DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\NuGet.Common.6.7.0.csproj" /> | ||
| <DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\NuGet.Configuration.6.7.0.csproj" /> | ||
| <DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\NuGet.Credentials.6.7.0.csproj" /> | ||
| <DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\NuGet.Frameworks.6.7.0.csproj" /> | ||
| <DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\NuGet.Packaging.6.7.0.csproj" /> | ||
| <DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\NuGet.Protocol.6.7.0.csproj" /> | ||
| <DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\NuGet.Versioning.6.7.0.csproj" /> |
Member
There was a problem hiding this comment.
This need to be listed in dependency order. For example, NuGet.Common has a dependency on NuGet.Frameworks. So NuGet.Frameworks should be listed before NuGet.Common. Here is a PR that can be used for reference to determine order: #740.
v-wuzhai
force-pushed
the
Jason/AddNugetPackages
branch
from
6a7e3cb to
16b8a3d
Compare
Contributor
Author
|
@mthalman I have fixed above comments, could you help to merge this? |
mthalman
approved these changes
Sep 15, 2023
Contributor
Author
|
/backport to release/8.0 |
Member
@v-wuzhai - you will have to manually backport. Edit: I see you already did. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following nuget packages to fix #7041