Skip to content

add Nuget.Commands and Nuget.Credentials 6.2.2 #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oleksandr-didyk merged 2 commits into from
Jun 6, 2023
Merged

add Nuget.Commands and Nuget.Credentials 6.2.2 #697

oleksandr-didyk merged 2 commits into from
Jun 6, 2023

Conversation

@oleksandr-didyk
Copy link
Contributor

@oleksandr-didyk oleksandr-didyk commented Jun 6, 2023

Fixes product pre-builts introduced by dotnet/installer#16592 by adding Nuget.Commands and Nuget.Credentials 6.2.2

@oleksandr-didyk oleksandr-didyk enabled auto-merge (squash) June 6, 2023 09:59
@oleksandr-didyk oleksandr-didyk mentioned this pull request Jun 6, 2023
Merged
mthalman
mthalman reviewed Jun 6, 2023
View reviewed changes
@MichaelSimons
Copy link
Member

MichaelSimons commented Jun 6, 2023

Have you verified Arcade is not loading these? Given arcade is a toolset repo, there is a good chance they are.

@oleksandr-didyk
Copy link
Contributor Author

oleksandr-didyk commented Jun 6, 2023 •
edited
Loading

Have you verified Arcade is not loading these? Given arcade is a toolset repo, there is a good chance they are.

Viktor disabled bundling of Nuget.* packages with Arcade's projects as mentioned in #673 (comment). That was the original reason we could use SBRPed Nuget for Arcade.

I will test it out with the VMR just to be safe

@MichaelSimons
Copy link
Member

MichaelSimons commented Jun 6, 2023

Viktor disabled bundling of Nuget.* packages with Arcade's projects as mentioned in #673 (comment). That was the original reason we could use SBRPed Nuget for Arcade.

Yes but technically it is possible for a nuget package to reference 6.2.2 which would load the SBRP.

@oleksandr-didyk
Copy link
Contributor Author

oleksandr-didyk commented Jun 6, 2023

I will test it out with the VMR just to be safe

The build passed, Nuget* pre-builts are not present

@oleksandr-didyk oleksandr-didyk merged commit 9eb0813 into dotnet:main Jun 6, 2023
@oleksandr-didyk oleksandr-didyk deleted the add-nuget-commands-credentials-6-2-2 branch June 7, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mthalman mthalman mthalman left review comments

@MichaelSimons MichaelSimons MichaelSimons approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oleksandr-didyk @MichaelSimons @mthalman