Add SBRPs for Microsoft.CodeAnalysis.* 3.7.0 and 3.3.1 #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmitche
requested review from
MichaelSimons,
mthalman and
oleksandr-didyk
as code owners
MichaelSimons
approved these changes
Jun 2, 2023
mthalman
reviewed
Jun 2, 2023
Member
mthalman
left a comment
mthalman
left a comment
There was a problem hiding this comment.
Looks like some build errors for the VB package
Member
Author
|
Yeah, had to add 4.0.1's VB package, working on that now. |
…s' into add-microsoft-code-analysis-sbrps Fix issues in Microsoft.CodeAnalysis.VisualBasic 4.0.1
mmitche
force-pushed
the
add-microsoft-code-analysis-sbrps
branch
from
8c7b7e3 to
b68a007
Compare
Member
Author
|
Okay I think this is good now. |
mthalman
approved these changes
Jun 5, 2023
Comment on lines
50
to
53
| public sealed partial class VisualBasicExtensions | ||
| public static partial class VisualBasicExtensions | ||
| { | ||
| internal VisualBasicExtensions() { } | ||
|
|
Member
There was a problem hiding this comment.
Is there a bug logged for the incorrect generation here?
Member
Author
There was a problem hiding this comment.
MichaelSimons
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.