[release/10.0] Add patch to fix building identitymodel submodule#1522
Merged
MichaelSimons merged 2 commits intorelease/10.0from Jan 5, 2026
Merged
[release/10.0] Add patch to fix building identitymodel submodule#1522MichaelSimons merged 2 commits intorelease/10.0from
MichaelSimons merged 2 commits intorelease/10.0from
Conversation
Partial backport of dotnet/dotnet#4043
Fixes the FileVersion calculation issue as reported in GitHub issue #3388.
Merged
MichaelSimons
approved these changes
Jan 5, 2026
mmitche
added a commit
to dotnet/dotnet
that referenced
this pull request
Jan 13, 2026
Add patch to fixup building of identitymodel Port of dotnet/source-build-reference-packages#1522 ---- #### AI description (iteration 1) #### PR Classification Bug fix to correct the FileVersion calculation in the build configuration for identitymodel. #### PR Summary This pull request adds a patch that revises the FileVersion logic in the `build/common.props` file, ensuring that calculated version numbers exceed previously released values. - `build/common.props`: Modified the FileVersion element to use MSBuild arithmetic operations, setting the revision to be higher than 61231 and addressing the issue outlined in the linked GitHub issue. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial backport of dotnet/dotnet#4043