Add custom assembly attribute to all targeting packs#1239
Merged
NikolaMilosavljevic merged 10 commits intodotnet:mainfrom Apr 24, 2025
Merged
Add custom assembly attribute to all targeting packs#1239NikolaMilosavljevic merged 10 commits intodotnet:mainfrom
NikolaMilosavljevic merged 10 commits intodotnet:mainfrom
Conversation
MichaelSimons
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/source-build#5050, dotnet/source-build#5051
This PR adds the custom assembly attribute to all targeting pack assemblies. This was regenerated using the updated tooling. Going forward, poisoning will be able to detect if any targeting pack assemblies have been leaked to the shipping assets.
This PR also updates the relevant test to ensure we don't regress the new attributes.
Besides new attribute, here are minor changes in ILs, i.e. some updated comments and some minor up-to date generation changes.
I've completed a full source-build verification in a poisoned build.