Skip to content

Add System.CodeDom/8.0.0 needed by roslyn #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akoeplinger merged 2 commits into from
Apr 23, 2025
Merged

Add System.CodeDom/8.0.0 needed by roslyn #1232

akoeplinger merged 2 commits into from
Apr 23, 2025

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Apr 23, 2025

@ViktorHofer ViktorHofer requested a review from a team as a code owner April 23, 2025 17:17
@ViktorHofer ViktorHofer mentioned this pull request Apr 23, 2025
Merged
@ViktorHofer ViktorHofer enabled auto-merge (squash) April 23, 2025 17:18
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Apr 23, 2025

@dotnet/source-build looks like CI runs on an EOL container. Can you please help resolve this?

@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented Apr 23, 2025

@dotnet/source-build looks like CI runs on an EOL container. Can you please help resolve this?

This is presumably for public CI, and Ubuntu 18.04, right?

source-build-reference-packages/azure-pipelines/templates/stages/build.yml

Line 12 in b1bc853

demands: ImageOverride -equals Build.Ubuntu.1804.Amd64.Open

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Apr 23, 2025

Yeah that looks right. Feel free to push into my PR if you want to address this here.

@MichaelSimons
Copy link
Member

MichaelSimons commented Apr 23, 2025

@NikolaMilosavljevic, it looks like the 8.0 branch also needs updating but the pipeline changed enough you won't be able to backport.

@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented Apr 23, 2025

@NikolaMilosavljevic, it looks like the 8.0 branch also needs updating but the pipeline changed enough you won't be able to backport.

9.0 branch is also on Ubuntu.1804, but we can use the backport option.

@akoeplinger akoeplinger disabled auto-merge April 23, 2025 18:43
@akoeplinger
Copy link
Member

akoeplinger commented Apr 23, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 23, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger akoeplinger enabled auto-merge (squash) April 23, 2025 18:43
@akoeplinger
Copy link
Member

akoeplinger commented Apr 23, 2025

@NikolaMilosavljevic I cherry-picked the change here so we can unblock this PR

@akoeplinger akoeplinger merged commit 19eb5ea into release/9.0 Apr 23, 2025
4 checks passed
@ViktorHofer ViktorHofer deleted the AddSystemCodeDomToRelease90 branch April 23, 2025 18:59
@MichaelSimons MichaelSimons mentioned this pull request Apr 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelSimons MichaelSimons MichaelSimons approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ViktorHofer @NikolaMilosavljevic @MichaelSimons @akoeplinger