Various infra improvements #1191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ViktorHofer
commented
Mar 5, 2025
ViktorHofer
commented
- Simplify FilterImplicitAssemblyReferences target
- Add comments to a few settings
- Add missing aspnetcore KnownFrameworkReference targeting pack setting
- Disable P2Ps getting copied to a lib's output which makes the build significantly faster.
- Move the _FindDependencies property from props to targets and extend the comment on why the setting is necessary.
- Simplify FilterImplicitAssemblyReferences target - Add comments to a few settings - Add missing aspnetcore KnownFrameworkReference targeting pack setting - Disable P2Ps getting copied to a lib's output which makes the build significantly faster. - Move the _FindDependencies property from props to targets and extend the comment on why the setting is necessary.
mthalman
reviewed
Mar 5, 2025
Comment on lines
+50
to
+52
| <KnownFrameworkReference Update="@(KnownFrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App'))"> | ||
| <TargetingPackVersion Condition="'%(TargetFramework)' == 'net6.0'">6.0.2</TargetingPackVersion> | ||
| </KnownFrameworkReference> |
Member
There was a problem hiding this comment.
We also have a 6.0.2 version of Microsoft.NetCore.App.Ref. Does that need an entry like this as well?
Member
Author
There was a problem hiding this comment.
No, as there's also a 6.0.0 version of Microsoft.NETCore.App.Ref. When targeting net6.0 we need to use either 6.0.0 or 6.0.2, we can't use both. The existing 6.0.0 version is fine to be used here.
Ideally repositories wouldn't depend on the 6.0.2 Microsoft.NETCore.App.Ref targeting pack in source-build. Not sure what required it to be added.
MichaelSimons
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.