Normalize casing of targeting pack projects and nuspecs #1189
Conversation
All SBRP projects except the targeting packs consistently use the casing of the package id (+ "." + packageversion), i.e. `Microsoft.Extensions.Logging.8.0.0.csproj`. A few targeting pack projects didn't follow that casing. Similar for the nuspecs which should always be lower-cased. This is in preparation to use the live targeting packs in SBRP and remove the self SBRP dependency.
mthalman
left a comment
mthalman
left a comment
There was a problem hiding this comment.
Thoughts on updating the directory name to match this casing?
mthalman
left a comment
mthalman
left a comment
There was a problem hiding this comment.
These targeting packs are all generated from an internal tool. Ultimately, the tool should also be updated so that future targeting pack generations will use this desired casing. I believe it's caused by this line: (internal link). That sets the folder name by deriving it from the nuspec name (which is lowercase). Then other files, like csproj, get based off of the folder name, continuing the casing pattern.
The directory name is expected to be lower-case. I.e. see https://github.com/dotnet/source-build-reference-packages/tree/FixCasingOfTargetingPacks/src/referencePackages/src |
Yes it would be good to update whatever tool produces these targeting packs. Can someone please help with that? I filed dotnet/source-build#4933 as a tracking issue. |
All SBRP projects except the targeting packs consistently use the casing of the package id (+ "." + packageversion), i.e.
Microsoft.Extensions.Logging.8.0.0.csproj.A few targeting pack projects didn't follow that casing. Similar for the nuspecs which should always be lower-cased.
This is in preparation to use the live targeting packs in SBRP and remove the self SBRP dependency. This change is repo-local and doesn't impact the published SBRP artifacts.