Regen existing packages #1138
Merged
Regen existing packages #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSimons
commented
Jan 28, 2025
| <serviceable>true</serviceable> | ||
| <dependencies> | ||
| <group targetFramework=".NETCoreApp3.0"> | ||
| <!-- Manually updated to resolve 3.1.0 prebuilt. |
Member
Author
There was a problem hiding this comment.
I dropped this comment/customization because the code gen'd reference is not being changed.
MichaelSimons
commented
Jan 28, 2025
Member
Author
There was a problem hiding this comment.
Note this is a permissions change (made by the generate tooling). Not sure why the nuspec was defined as it was.
mthalman
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerated packages that contain source-edits. You don't see them because I re-applied the customizations after regenning the packages. There were a few that were able to be dropped. For example NuGet.LibraryModel.6.11.0.csproj was updated to make use of the common RequiredModifierAttributes.cs.